Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xf86-video-amdgpu
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • driver
  • xf86-video-amdgpu
  • Merge requests
  • !20

Fix crash when page flipping in multi-X-Screen/Zaphod mode

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michel Dänzer requested to merge daenzer/xf86-video-amdgpu:zaphod-crash-fix into master Dec 19, 2018
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

amdgpu_do_pageflip() indexed the flipdata->fb[] array indexing over config->num_crtc, but the flip completion routines, e.g., drmmode_flip_handler(), index that array via the crtc hw id from drmmode_get_crtc_id(crtc).

This is mismatched and causes indexing into the wrong array slot at flip completion -> Server crash.

Always use drmmode_get_crtc_id(crtc) for indexing into the array to fix this.

Tested on a dual-X-Screen setup with one video output assigned to each X-Screen, page-flipping an OpenGL app on either of both X-Screens. This used to crash when flipping on X-Screen 1, now it doesn't anymore.

Fixes: 9b6782c8 "Store FB for each CRTC in drmmode_flipdata_rec" (Ported from radeon commit 0058fd2ebf4c900b12f129984e98886a7ac84b2f) Reviewed-by: Michel Dänzer michel.daenzer@amd.com Signed-off-by: Mario Kleiner mario.kleiner.de@gmail.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: zaphod-crash-fix