Skip to content

Mass code cleanup and other janitorial work

Alan Coopersmith requested to merge alanc/xkbcomp:misc into master
  • gitlab CI: stop requiring Signed-off-by in commits
  • Eliminate 20 -Wimplicit-fallthrough warnings
  • Remove register keyword from variable declarations
  • Variable scope reductions
  • Use C99 struct initializers
  • Delete unused uTmpAlloc/uTmpFree wrappers around alloca()
  • Replace uAlloc() and uTypedAlloc() with direct malloc() calls
  • Replace uCalloc() and uTypedCalloc() with direct calloc() calls
  • Replace uTypedRealloc() with direct reallocarray() calls
  • Replace uTypedRecalloc() with direct recallocarray() calls
  • Replace uFree() with direct free() calls
  • Remove unnecessary checks for NULL pointers before calling free()
  • Replace Opaque with direct usage of void *
  • Remove unnecessary casts from memcpy() calls
  • Remove unnecessary casts from bzero() calls
  • Replace malloc()+bzero() pairs with calloc() calls
  • Fix 106 missing-field-initializers warnings in misc.c
  • Replace && with & for bitwise comparison
  • Use asprintf() if the platform supports it
  • Handle -Wstringop-truncation warning in HandleOverlayDef()
  • Remove #ifdef sgi sections
  • FindKeypadVMod: check xkb is not NULL before dereference, not after
  • XkbAddDirectoryToPath: don't leak existing paths on realloc() failure
  • Mark more functions and variables static
  • Remove unused "no indent" (NOI) debug functions
  • Only build debug infrastructure if DEBUG is defined
  • Stop building more unused functions
  • Use unsigned ints when shifting to create bitmasks
  • Mark more pointers as const
  • Replace calloc(strlen())+strcpy() pairs with strdup() calls

Merge request reports