Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xedit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • app
  • xedit
  • Merge requests
  • !1

Fix segfault when tags file isn't found

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Niclas Zeising requested to merge zeising/xedit:zeising/segfault into master Sep 11, 2019
  • Overview 0
  • Commits 1
  • Changes 1

Fix a segfault when the tags file isn't found. xedit tries to construct a path to the tags file (by defailt ${HOME}/tags), using amongst other things basename(3). However, basename is called with an immutable string which causes segfaults on FreeBSD, since basename(3) uses the provided buffer to store it's result. Change the code to duplicate the string with strdup() and call basename on the duplicated string instead.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: zeising/segfault