Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xdm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • app
  • xdm
  • Merge requests
  • !10

chooser: avoid free of uninitialized pointer in allocation failure cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alan Coopersmith requested to merge alanc/xdm:parfait into master Apr 30, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Resolves issue found by Oracle Parfait static analyzer:

Error: Uninitialised memory
   Uninitialised memory [uninitialised-mem] (CWE 456):
      Possible access to uninitialised memory referenced by 'new->fullname'
      Memory 'new->fullname' accessed at byte offset '8'
        at line 357 of app/xdm/chooser/chooser.c in function 'AddHostname'.
        Write does not overlap at line 355
          new allocated at line 329
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: parfait