Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xditview xditview
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • xorgxorg
  • app
  • xditviewxditview
  • Merge requests
  • !7

Assorted fixes and cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alan Coopersmith requested to merge alanc/xditview:cleanup into master Jan 15, 2023
  • Overview 0
  • Commits 10
  • Pipelines 2
  • Changes 14

The biggest change is actually enabling the USE_XFT code that's been in since the import from XFree86.

  • lex.c: increment length counters when adding to buffer
  • Replace strcpy() calls with strncpy() or memcpy()
  • Add bounds check to getstr()
  • More variable scope reductions as recommended by cppcheck
  • Initialize more variables in their declarations
  • configure: Add --with-xft and --without-xft flags to control USE_XFT
  • Mark more char * as const
  • Add CWARNFLAGS to AM_CFLAGS
  • GetLine: resolve -Wmaybe-uninitialized warning
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cleanup