Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xauth
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • app
  • xauth
  • Merge requests
  • !12

Fix off-by-one in quote-stripping routines

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alan Coopersmith requested to merge alanc/xauth:parfait into master Apr 10, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Reported by Oracle Parfait:

Error: Buffer overrun
   Buffer overflow [buffer-overflow] (CWE 120):
      In pointer dereference of key[(len - 1)] with index (len - 1)
      Array size >= 1 bytes, index >= 1
        at line 1647 of process.c in function 'do_add'.

Error: Buffer overrun
   Buffer overflow [buffer-overflow] (CWE 120):
      In pointer dereference of authdata[(authdatalen - 1)] with index (authdatalen - 1)
      Array size is ??? bytes, index is ???
        at line 1965 of process.c in function 'do_generate'.
Edited Apr 10, 2022 by Alan Coopersmith
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: parfait