Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
F
fonttosfnt
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • xorg
  • app
  • fonttosfnt
  • Merge Requests
  • !6

Merged
Opened Feb 07, 2020 by Michele Guerini Rocco@rnhmjojContributor

Fix uninitialised memory write

  • Overview 1
  • Commits 2
  • Changes 2

I found this while investigating non determinstic builds across different machines. It took me a while because I looked at the checksums before realizing the date fields (appearing much later in the font file) were different. Then I realized it was a date but strangely it wasn't changing with faketime and eventually I figured macTime(hi, lo) was returning -1, leaving hi and lo uninitialised.

Hope you'll find this fix appropriate, otherwise cosider this as a simple bug report.

Edited Feb 07, 2020 by Michele Guerini Rocco
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: xorg/app/fonttosfnt!6
Source branch: master