Skip to content
Snippets Groups Projects
  1. Jul 02, 2020
  2. Jul 01, 2020
  3. Jun 30, 2020
  4. Jun 25, 2020
    • Seungha Yang's avatar
      docs: Specify UTF-8 encoding everywhere · 6ca93950
      Seungha Yang authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      Otherwise some non-English character might be broken depending on
      OS and/or locale.
      
      Part-of: <gstreamer/gstreamer!545>
      6ca93950
    • Mathieu Duponchelle's avatar
      hooks: add opt-in cache update hook · 65e89d45
      Mathieu Duponchelle authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      CI now checks that plugin caches are up to date, for example
      when adding a new property to an element.
      
      This is something pretty easy to forget, and it can be checked
      in a pre-commit hook provided the cache generator generates no
      unnecessart diff on the developer's machine. This is now the
      case for me in core, -base and -good, and eventually all the
      repositories should behave appropriately, at least on my
      development machine.
      
      The new check in the pre-commit hook is only performed when
      the user is in the development environment (it checks
      $MESON_BUILD_ROOT to determine that), and when the developer
      has opted-in by setting `GST_CACHE_HOOK=enabled`. That is
      because the hook will actually rebuild the cache with ninja,
      and modify it in the source directory, that's not a behaviour
      we want to enable by default.
      
      Part-of: <gstreamer/gstreamer!546>
      65e89d45
  5. Jun 24, 2020
    • Seungha Yang's avatar
      gst-inspect: Use gst_info_strdup_vprintf to print string · 57d29e7f
      Seungha Yang authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      g_vprintf() will write a string binary to stdout directly using fwrite().
      So, depending on character in the string, fwrite to stdout can
      print broken one but printf family might not cause the issue.
      
      Part-of: <gstreamer/gstreamer!544>
      57d29e7f
    • Michael Olbrich's avatar
      bus: clear bus->priv->signal_watch immediately when the source is removed · 1206a60b
      Michael Olbrich authored
      There is a race-condition that can trigger the assertion in
      gst_bus_add_signal_watch_full():
      
      If gst_bus_add_signal_watch_full() is called immediately after
      gst_bus_remove_signal_watch() then bus->priv->signal_watch may still be set
      because gst_bus_source_dispose() or gst_bus_source_finalize() was not yet
      called.
      This happens if the corresponding GMainContext has the source queued for
      dispatch. In this case, the following dispatch will only unref and delete
      the signal_watch because it was already destroyed. Any pending messages
      will remain until a new watch is installed.
      
      So bus->priv->signal_watch can be cleared immediately when the watch is
      removed. This avoid the race condition.
      
      Part-of: <!543>
      1206a60b
  6. Jun 23, 2020
  7. Jun 22, 2020
    • Sebastian Dröge's avatar
      ghostpad: Deprecate gst_ghost_pad_construct() · 63c19456
      Sebastian Dröge authored
      Instead do everything it did as part of GObject::constructed() and
      change the function to always return TRUE.
      
      gst_ghost_pad_construct() was meant to be called by subclasses right
      after construction of the object to finish construction as it can fail
      in theory. In practice it's impossible for it to fail, even more so if
      called directly from GObject::constructed(): The only failure condition
      is if the newly created proxy pad already has a parent, which is
      impossible at this point as nothing else can have a reference to it.
      
      Part-of: <gstreamer/gstreamer!540>
      63c19456
  8. Jun 20, 2020
  9. Jun 19, 2020
  10. Jun 18, 2020
    • Roman Shpuntov's avatar
      systemclock: Fix clock time conversion on Windows/xbox · fd280c09
      Roman Shpuntov authored and Sebastian Dröge's avatar Sebastian Dröge committed
      The returned ratio can be bigger than GST_SECOND, in which case we would
      forever return 0 for the system clock time. Even in other cases if it's
      close to GST_SECOND it would result in accuracy loss.
      
      Instead of doing the division by GST_CLOCK_TIME_NONE during
      initialization once, do it every time the clock time is requested.
      
      Fixes #575
      
      Part-of: <!534>
      fd280c09
  11. Jun 16, 2020
    • Edward Hervey's avatar
      gst: Delay creation of threadpools · 31e6d766
      Edward Hervey authored and Edward Hervey's avatar Edward Hervey committed
      Since glib 2.64, gthreadpool will start waiting on a GCond immediately upon
      creation. This can cause issues if we fork *before* actually using the
      threadpool since we will then be signalling that GCond ... from another process
      and that will never work.
      
      Instead, delay creationg of thread pools until the very first time we need
      them. This introduces a minor (un-noticeable) delay when needing a new thread
      but fixes the issues for all users of GSTreamer that will call gst_init, then
      fork and actually start pipelines.
      
      See https://gitlab.gnome.org/GNOME/glib/-/issues/2131 for more context.
      
      Part-of: <gstreamer/gstreamer!531>
      31e6d766
  12. Jun 15, 2020
  13. Jun 12, 2020
  14. Jun 11, 2020
  15. Jun 10, 2020
  16. Jun 09, 2020
  17. Jun 08, 2020
  18. Jun 06, 2020
Loading