• Pekka Paalanen's avatar
    libweston: drop a misleading dmabuf comment · 69dcd23c
    Pekka Paalanen authored
    This comment was added in 230f3b1b with the
    intent that if we had an information table about pixel formats (which we do
    have today), we could implement more sanity checks like ensuring that width
    pixels fit into stride.
    
    Daniel Vetter said on #dri-devel IRC recently:
    
    	< danvet> since userspace shouldn't look at stride for buffers with
    	modifiers, only pass it around unchanged
    
    I asked for clarification. It was expected that userspace would not do any kind
    of sanity checks as modifiers could change everything.
    
    Let's remove the misleading code comment so that people don't get the idea of
    adding more well-intended but ill-advised sanity checks. If more checks are
    added, they must take the modifier into account, which the existing checks do
    not do.
    
    After 5 years, it is far too late to remove our existing sanity checks, but we
    can attempt to not cause any more damage that would restrict what people can do
    in the kernel.
    Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.com>
    69dcd23c
Name
Last commit
Last update
..
backend-drm Loading commit data...
backend-fbdev Loading commit data...
backend-headless Loading commit data...
backend-rdp Loading commit data...
backend-wayland Loading commit data...
backend-x11 Loading commit data...
renderer-gl Loading commit data...
animation.c Loading commit data...
backend.h Loading commit data...
bindings.c Loading commit data...
clipboard.c Loading commit data...
compositor.c Loading commit data...
content-protection.c Loading commit data...
data-device.c Loading commit data...
dbus.c Loading commit data...
dbus.h Loading commit data...
git-version.h.meson Loading commit data...
input.c Loading commit data...
launcher-direct.c Loading commit data...
launcher-impl.h Loading commit data...
launcher-logind.c Loading commit data...
launcher-util.c Loading commit data...
launcher-util.h Loading commit data...
launcher-weston-launch.c Loading commit data...
libinput-device.c Loading commit data...
libinput-device.h Loading commit data...
libinput-seat.c Loading commit data...
libinput-seat.h Loading commit data...
libweston-internal.h Loading commit data...
linux-dmabuf.c Loading commit data...
linux-dmabuf.h Loading commit data...
linux-explicit-synchronization.c Loading commit data...
linux-explicit-synchronization.h Loading commit data...
linux-sync-file-uapi.h Loading commit data...
linux-sync-file.c Loading commit data...
linux-sync-file.h Loading commit data...
log.c Loading commit data...
meson.build Loading commit data...
noop-renderer.c Loading commit data...
pixel-formats.c Loading commit data...
pixel-formats.h Loading commit data...
pixman-renderer.c Loading commit data...
pixman-renderer.h Loading commit data...
plugin-registry.c Loading commit data...
screenshooter.c Loading commit data...
spring-tool.c Loading commit data...
timeline.c Loading commit data...
timeline.h Loading commit data...
touch-calibration.c Loading commit data...
vertex-clipping.c Loading commit data...
vertex-clipping.h Loading commit data...
weston-launch.c Loading commit data...
weston-launch.h Loading commit data...
weston-log-file.c Loading commit data...
weston-log-flight-rec.c Loading commit data...
weston-log-internal.h Loading commit data...
weston-log-wayland.c Loading commit data...
weston-log.c Loading commit data...
zoom.c Loading commit data...