Skip to content
Snippets Groups Projects

xdgmimeglob: Fix a memory leak on a duplicate-entry path

Merged Philip Withnall requested to merge pwithnall/xdgmime:glob-list-leak into master
All threads resolved!

Rather than strdup()ing strings when passing them into _xdg_glob_list_append(), strdup() them inside the function instead.

This avoids a leak in the case that the list entry (tuple of data and mime_type) already exists in the list.

Signed-off-by: Philip Withnall pwithnall@gnome.org

Merge request reports

Pipeline #1152704 failed

Pipeline failed for be1f98d4 on pwithnall:glob-list-leak

Approved by

Merged by Philip WithnallPhilip Withnall 11 months ago (Apr 15, 2024 2:50pm UTC)

Merge details

  • Changes merged into master with be1f98d4.
  • Deleted the source branch.

Pipeline #1154555 failed

Pipeline failed for be1f98d4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading