Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xdgmime
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xdg
  • xdgmime
  • Merge requests
  • !27

xdgmimemagic: Add an assertion to clarify state after hitting an error

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/xdgmime:parse-error-state into master May 10, 2022
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

This introduces no functional changes, but should help guide static analysis. Currently, scan-build thinks that match could be used after being freed, because it assumes that _xdg_mime_magic_parse_error() could return any XdgMimeMagicState.

See the trace here: https://gnome.pages.gitlab.gnome.org/-/glib/-/jobs/1993739/artifacts/_scan_build/meson-logs/scanbuild/2022-05-10-050755-3977-1/report-6f5f44.html#EndPath

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: parse-error-state