Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xdgmime
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xdg
  • xdgmime
  • Merge requests
  • !18

test-mime-data: fail when an error occurs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Igor Kushnir requested to merge igorkushnir/xdgmime:test-mime-data-fail-on-error into master Oct 11, 2021
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

This change should prevent test file omissions like the one fixed in shared-mime-info@66c73d06

Always print summary. The condition (error > 0 || failed > 0) was incomplete: xmatch > 0 should have been checked as well. shared-mime-info's test_mime.sh passes a list with many expected failures to test-mime-data, so the condition failed > 0 is always true. Therefore printing the summary unconditionally makes no difference, unless there are other users of test-mime-data that don't have expected failures in their test case lists.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: test-mime-data-fail-on-error