Draft: Don't give up too early when collecting mime types

Since returning exactly one match has special significance, don't give up matching before we've found at least 2 types. Also, make sure that we don't return the same mime type more than once. Bug 541236.

Helps: #32

This was to fix this issue in GLib, and it was confirmed as fixing the issue, with some remaining comments which might need to be factored into a review here.

My inclination is to just merge all of Emmanuel's MRs. They do not appear to be malware, and it's unlikely that anybody who understands this code is going to review them closely. (Clearly, nobody is actively watching this repo handling MRs.)

Philip, it looks like you have commit access to this repo. I don't.

added 1 commit

• 7e73f326 - Don't give up too early when collecting mime types

Compare with previous version

mentioned in issue #32

resolved all threads

added 15 commits

• 7e73f326...c5011886 - 14 commits from branch xdg:master
• 9e8a5673 - Don't give up too early when collecting mime types

Compare with previous version

added 2 commits

• 0122cb54 - 1 commit from branch xdg:master
• 1e550b15 - Don't give up too early when collecting mime types

Compare with previous version

enabled an automatic merge when the pipeline for 1e550b15 succeeds

canceled the automatic merge

So I very nearly merged this, but this comment on the GLib issue tracker persuaded me that all is not correct here. This code is gnarly, and I don't plan to look closer to try sorting it out.

Regardless of whether you care to look closer or not, thanks for (mostly) successfully reconciling the unnecessary differences between GIO vs. upstream!

marked this merge request as draft

I'm going to reject this based on this old review feedback.

closed