Skip to content
Snippets Groups Projects

thumbnail: Add x-large and xx-large thumbnail spec size

Merged Bastien Nocera requested to merge wip/hadess/xlarge-thumbnail into master
All threads resolved!

Rather than adding hi-dpi specific text to the thumbnail specification, we expect code that calls out to thumbnailers to automatically ask for the right size of thumbnail to be displayed, depending on the level of integration that the toolkit provides.

The x-large "512x512" size could be used as a 512x512 size for non-hi-dpi displays, or equivalent to a 256x256 logical size of displays with a 2x DPI.

The "x*-large" name also has the benefit of being easily extensible without getting a thesaurus out.

Closes: #15 (closed)

Merge request reports

Pipeline #245545 passed

Pipeline passed for 47258f22 on wip/hadess/xlarge-thumbnail

Merged by Bastien NoceraBastien Nocera 4 years ago (Dec 17, 2020 5:00pm UTC)

Loading

Pipeline #245547 passed

Pipeline passed for 47258f22 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bastien Nocera added 1 commit

    added 1 commit

    • 9e938b61 - thumbnail: Add x-large and xx-large thumbnail spec size

    Compare with previous version

  • Bastien Nocera resolved all threads

    resolved all threads

  • Méven Car
  • Bastien Nocera added 1 commit

    added 1 commit

    • e880c4f4 - thumbnails: Fix a number of typos

    Compare with previous version

  • Bastien Nocera resolved all threads

    resolved all threads

  • Bastien Nocera added 2 commits

    added 2 commits

    • dbffd26e - thumbnails: Fix a number of typos
    • fb6852d9 - thumbnail: Add x-large and xx-large thumbnail spec size

    Compare with previous version

  • This looks good to me @faure @StefanBruens ?

  • At least with xxx-large you are very prone to hit some spam filters ;-)

  • Bastien Nocera added 1 commit

    added 1 commit

    • 47258f22 - web-export: Export the new version of the thumbnail spec

    Compare with previous version

  • Please register or sign in to reply
    Loading