Skip to content

RFC: Use struct timeval for callbacks to help detect ABI breakage

Natanael Copa requested to merge ncopa/startup-notification:fix-64bit-time_t into master

The commit a7e49fef (Fix crash on 32bit architectures where time_t is 64 bit) introduces crashes unless caller code is adapted to use time_t. This is not detected by compiler, which happily passes the pointers.

To help detect and fix broken code we change the number of arguments passed so compiler will catch breakages for us.

This breaks the ABI.

ref: https://gitlab.alpinelinux.org/alpine/aports/-/issues/15441 ref: https://gitlab.xfce.org/xfce/xfwm4/-/commit/f68c04ba8591615e5ee615865daf50c23b35ef33

fixes #6

Merge request reports