Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • S shared-mime-info
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • xdg
  • shared-mime-info
  • Merge requests
  • !144

audio/vnd.dts.hd: include parent type magic in magic match

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ville Skyttä requested to merge work/scop/dtshd-magic into master Aug 11, 2021
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

Matching just 0x64582025 within the first 18725 bytes of any file is prone to false positives.

The priority of the magic match here being bumped to 60 seems to indicate intent to make it take precedence over the parent audio/vnd.dts. But we should take the parent magic into account here as it does not "inherit" with sub-class-of.

As the comment for this match says "16bits HD be", accept only "16bits core be" as the parent at least for now, not all possible parent magics -- it would not seem consistent to have it in "14bits" variants, or the "16bits core le" one. The test case we have for this is one matching "16bits core be".

Refs #166 (closed) Refs #167 (closed)

This could actually fix #167 (closed), but without a test file, can't say for sure.

Edited Aug 11, 2021 by Ville Skyttä
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/scop/dtshd-magic