Skip to content
Snippets Groups Projects

video/mp4: recognize mpeg4 v1 video

Merged Adam Hooper requested to merge adamhooper/shared-mime-info:mp4v1 into master
1 unresolved thread

My first merge request! Should detect MPEG4 v1 files as video/mp4.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 492 492 # Copied from https://github.com/inAudible-NG/audible-samples
    493 493 test.aa audio/x-pn-audibleaudio
    494 494 test.aax audio/x-pn-audibleaudio
    495 # MPEG-4 files
    496 mp4v1-video-header video/mp4
    497 mp4v2-video-header video/mp4
  • If you rebase your branch on top of master (or allow others to push to it), you can check the test failure yourself now.

  • Adam Hooper added 5 commits

    added 5 commits

    Compare with previous version

  • Author Contributor

    A-ha -- I guess I didn't figure out how to run the tests properly. (XDG_DATA_HOME=. make check, for future contributors.)

    I made the tests pass by renaming these files to ".mp4". Just to confirm: this does still test the magic numbers, right?

    I've rebased on top of master and pushed with --force. Should be good to go!

  • A-ha -- I guess I didn't figure out how to run the tests properly. (XDG_DATA_HOME=. make check, for future contributors.)

    The test suite is explained in the HACKING file. Setting XDG_DATA_HOME shouldn't be necessary for it to run either, and I'd be happy to check if you had the logs of your attempts to run it simply as make check (in a separate issue, of course).

    I made the tests pass by renaming these files to ".mp4". Just to confirm: this does still test the magic numbers, right?

    Yes, as mentioned at the top of the file, and in the HACKING file, 3 tests are run, and 2 of them rely on the suffix being what it would be "in the wild", with the magic data eventually used to differentiate mime-types.

    I've rebased on top of master and pushed with --force. Should be good to go!

    Cool, although all in the same commit would have done.

  • Cool, although all in the same commit would have done.

    That silly "squash commits" button didn't actually squash anything, sorry about that.

  • Author Contributor

    Thanks!

    I maintain a Java library, https://github.com/overview/mime-types. You may see more of me as other bug reports trickle in.

    Edited by Adam Hooper
  • Please register or sign in to reply
    Loading