Skip to content

Fix build errors with -Werror and NDEBUG

John Lindgren requested to merge jlindgren90/wlroots:build-errors into master

(line numbers are from 0.17 branch)

../examples/pointer.c: In function ‘output_frame_notify’:
../examples/pointer.c:101:30: error: unused variable ‘renderer’ [-Werror=unused-variable]
  101 |         struct wlr_renderer *renderer = state->renderer;
      |                              ^~~~~~~~

../render/pass.c: In function ‘wlr_render_pass_add_texture’:
../render/pass.c:32:40: error: unused variable ‘box’ [-Werror=unused-variable]
   32 |                 const struct wlr_fbox *box = &options->src_box;
      |                                        ^~~

../render/pixman/renderer.c: In function ‘pixman_read_pixels’:
../render/pixman/renderer.c:475:45: error: unused variable ‘drm_fmt’ [-Werror=unused-variable]
  475 |         const struct wlr_pixel_format_info *drm_fmt =
      |                                             ^~~~~~~

../backend/wayland/backend.c: In function ‘linux_dmabuf_feedback_v1_handle_tranche_formats’:
../backend/wayland/backend.c:217:16: error: unused variable ‘table_cap’ [-Werror=unused-variable]
  217 |         size_t table_cap = feedback_data->format_table_size /
      |                ^~~~~~~~~

../types/output/render.c: In function ‘output_pick_format’:
../types/output/render.c:196:31: error: unused variable ‘allocator’ [-Werror=unused-variable]
  196 |         struct wlr_allocator *allocator = output->allocator;
      |                               ^~~~~~~~~

../types/wlr_compositor.c: In function ‘wlr_surface_unlock_cached’:
../types/wlr_compositor.c:840:14: error: variable ‘found’ set but not used [-Werror=unused-but-set-variable]
  840 |         bool found = false;
      |              ^~~~~

../types/wlr_screencopy_v1.c: In function ‘frame_handle_output_commit’:
../types/wlr_screencopy_v1.c:273:30: error: unused variable ‘renderer’ [-Werror=unused-variable]
  273 |         struct wlr_renderer *renderer = output->renderer;
      |                              ^~~~~~~~
../types/wlr_screencopy_v1.c: In function ‘capture_output’:
../types/wlr_screencopy_v1.c:525:30: error: unused variable ‘renderer’ [-Werror=unused-variable]
  525 |         struct wlr_renderer *renderer = output->renderer;
      |                              ^~~~~~~~

../types/wlr_shm.c: In function ‘wlr_shm_create’:
../types/wlr_shm.c:501:36: error: variable ‘has_xrgb8888’ set but not used [-Werror=unused-but-set-variable]
  501 |         bool has_argb8888 = false, has_xrgb8888 = false;
      |                                    ^~~~~~~~~~~~
../types/wlr_shm.c:501:14: error: variable ‘has_argb8888’ set but not used [-Werror=unused-but-set-variable]
  501 |         bool has_argb8888 = false, has_xrgb8888 = false;
      |              ^~~~~~~~~~~~

../xwayland/selection/dnd.c: In function ‘xwm_dnd_send_drop’:
../xwayland/selection/dnd.c:124:38: error: unused variable ‘dest’ [-Werror=unused-variable]
  124 |         struct wlr_xwayland_surface *dest = xwm->drag_focus;
      |                                      ^~~~
../xwayland/selection/dnd.c:122:26: error: unused variable ‘drag’ [-Werror=unused-variable]
  122 |         struct wlr_drag *drag = xwm->drag;
      |                          ^~~~
../xwayland/selection/dnd.c: In function ‘xwm_dnd_send_leave’:
../xwayland/selection/dnd.c:137:38: error: unused variable ‘dest’ [-Werror=unused-variable]
  137 |         struct wlr_xwayland_surface *dest = xwm->drag_focus;
      |                                      ^~~~
../xwayland/selection/dnd.c:135:26: error: unused variable ‘drag’ [-Werror=unused-variable]
  135 |         struct wlr_drag *drag = xwm->drag;
      |                          ^~~~

../types/wlr_output_management_v1.c: In function ‘head_send_state’:
../types/wlr_output_management_v1.c:762:22: error: variable ‘found’ set but not used [-Werror=unused-but-set-variable]
  762 |                 bool found = false;
      |                      ^~~~~

Merge request reports