Skip to content

output: replace wlr_render_timer arg with wlr_buffer_pass_options

Simon Ser requested to merge emersion/wlroots:output-begin-render-pass-simple into master

This scales better when more render pass options are added.

Historical MR description:

wlr_output_begin_render_pass() is supposed to be the simple, easy-to-use API for basic compositors. wlr_render_timer is a bit of an advanced use-case, compositors can easily replace wlr_output_begin_render_pass() with a configure_swapchain + acquire + attach_buffer combo if they need to use that. Moreover, I'm worried that directly pasing the wlr_render_timer won't scale: we don't want to add one new arg per render option.

This breaking change is a bit unfortunate. Maybe a less intrusive option would be to replace the wlr_render_timer arg with wlr_render_pass_options, that way most compositors (ie. these passing NULL) won't need to be updated once again and the scalability issue is gone.

Edited by Simon Ser

Merge request reports