Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • wlroots wlroots
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 345
    • Issues 345
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • wlrootswlroots
  • wlrootswlroots
  • Merge requests
  • !3974

Draft: cursor: overhaul

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kirill Primak requested to merge vyivel/wlroots:simplify-cursor into master Jan 18, 2023
  • Overview 2
  • Commits 3
  • Pipelines 2
  • Changes 10

Depends on !3970


This MR greatly simplifies wlr_cursor, which at the moment does multiple things at once:

  • applies (device-specific) coordinate transformations → this functionality is moved out to a helper
  • acts as a proxy for pointer-like devices → removed
    • can be reintroduced as another helper, but that doesn't seem very useful
    • this is the reason why some input events still have the device pointer in them
  • manages wlr_output_cursor objects (this includes setting surfaces/images) → the only thing wlr_cursor does now
Edited Jan 29, 2023 by Kirill Primak
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: simplify-cursor