Skip to content

backend/drm: disable all CRTCs after VT switch

Simon Ser requested to merge emersion/wlroots:disable-crtcs-after-vt-switch into master

When the user switches away from the VT where wlroots is running, the new DRM master may mutate the KMS state in an arbitrary manner. For instance, let's say wlroots uses the following connector/CRTC mapping:

  • CRTC 42 drives connector DP-1
  • CRTC 43 drives connector DP-2

Then the new DRM master may swap the mapping like so:

  • CRTC 42 drives connector DP-2
  • CRTC 43 drives connector DP-1

wlroots needs to restore its own state when the user switches back. Some state is attached to wlr_drm_crtc (e.g. current FB), so reading back and adopting the CRTC/connector mapping left by the previous DRM master would be complicated (this was the source of other bugs in the past, see 1).

With the previous logic, wlroots merely tries to restore the state of each connector one after the other. This fails in the scenario described above: the kernel refuses to use CRTC 42 for DP-1, because that CRTC is already in-use for DP-2.

Unfortunately with the legacy uAPI it's not possible to restore the state in one go. We need to support both legacy and atomic uAPIs, so let's fix the bug for the legacy uAPI first, and then improve the situation for the atomic uAPI as a second step 2.

We need to disable the CRTCs we're going to switch the connectors for. This sounds complicated, so let's just disable all CRTCs to simplify. This causes a black screen because of the on/off modesets, but makes VT switch much more reliable, so I'll take it.

Closes: #3342 (closed)

Merge request reports