Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • wlroots wlroots
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 344
    • Issues 344
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • wlrootswlroots
  • wlrootswlroots
  • Merge requests
  • !3966

render/gles2: use byte-aligned rows for glReadPixels

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open M. Stoeckl requested to merge mstoeckl/wlroots:gles-read-align into master Jan 14, 2023
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

This fixes a bug with a screenshot stride mismatch I encountered when using:

  • Sway with modification to allow RGB565 buffers, with: https://github.com/mstoeckl/sway/tree/extra-bit-depths
  • Wayshot modified to take screenshots of RGB565 buffers, using the following branch: https://github.com/waycrate/wayshot/pull/32 . (grim does not work here, since a) it takes a screenshot of the complete output, not a region, and then edits it down b) Pixman cannot handle RGB565 buffers where stride % 4 = 2.)

To reproduce the issue/check that this MR corrects the behavior:

swaymsg output '*' render_bit_depth 5
wayshot -s "0 0 101 100" -f out.png

Documentation for glPixelStorei / GL_PACK_ALIGNMENT: https://docs.gl/es2/glPixelStorei

Edited Jan 14, 2023 by M. Stoeckl
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gles-read-align