Skip to content

Revert "backend/drm: fail instead of stripping a modifier"

Simon Ser requested to merge github/fork/emersion/revert-fb-for-bo-modifier-check into master

This reverts commit f9f90b41.

gbm_bo_get_modifier may return a modifier in these cases:

  • The kernel doesn't support modifiers but Mesa does
  • WLR_DRM_NO_MODIFIERS=1 is set

However, in both of these cases, the gbm_bo has been allocated without modifiers.

There is already a check in drm_fb_create for modifiers: wlr_drm_format_set_has will make sure buffers with an explicit modifier will be rejected if the DRM backend doesn't support them. So no need for an additional check in get_fb_for_bo.

Closes: https://github.com/swaywm/wlroots/issues/2896

cc @kennylevinsen

Merge request reports