Skip to content
Snippets Groups Projects

[WIP] Headless export-dmabuf

Closed [WIP] Headless export-dmabuf
github/fork/any1/headless-export-dmabuf into master
Closed Andri Yngvason requested to merge github/fork/any1/headless-export-dmabuf into master

This is very much work in progress, but it does work quite well.

Things I'd like some feedback on:

  • GBM buffer allocation. Would it be better to get the render node from DRM if the renderer belongs to DRM?
  • The way I added glEGLImageTargetRenderbufferStorageOES into the backend is rather ugly. Suggestions?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
render/wlr_renderer.c
164 164 return r->impl->blit_dmabuf(r, dst, src);
165 165 }
166 166
167 GLuint wlr_renderer_renderbuffer_from_image(struct wlr_renderer *r,
  • Simon Ser
  • Simon Ser
    Simon Ser @emersion ·
    Owner

    Review: Commented

    I haven't looked into this in detail, but here are some general comments.

    Something quite similar has been worked on for the DRM backend. I think ti would make sense to use the renderer v6's wlr_swapchain here too. See https://github.com/swaywm/wlroots/pull/2240

    GBM buffer allocation. Would it be better to get the render node from DRM if the renderer belongs to DRM?

    It may make sense to add wlr_renderer_get_fd. See https://github.com/swaywm/wlroots/pull/1376#issuecomment-634552001

  • Simon Ser
    Simon Ser @emersion ·
    Owner

    GBM buffer allocation. Would it be better to get the render node from DRM if the renderer belongs to DRM?

    https://github.com/swaywm/wlroots/pull/1376 now has wlr_renderer_get_drm_fd.

  • Simon Ser
    Simon Ser @emersion ·
    Owner

    I've adapted #2240 for the headless backend: https://github.com/swaywm/wlroots/pull/2374

    • Please register or sign in to reply