Skip to content

Declare wlr_seat globals as extern

Simon Ser requested to merge github/fork/khardix/pr/extern_wlr_seat into master

Created by: khardix

When compiling wlroots with GCC 10, the linking fails with multiple definition of 'default_pointer_grab_impl' and similar errors for default_keyboard_grab_impl and default_touch_grab_impl. Full error: gcc-10-ld.err.txt

If I recall my C correctly, these should be marked extern – they just declare that the objects exist somewhere in the linked library, not necessarily in the current translation unit. Adding the extern qualifier causes the linking to pass successfully.

Merge request reports