Skip to content

drag-icon map and unmap fixes

Simon Ser requested to merge github/fork/acrisci/drag-icon-unmap into master

Created by: acrisci

The event is only emitted on unmap, so I renamed it to unmap. I don't like the old approach of emitting both map/unmap on the same event because it's inconsistent with the shell behavior. (I wrote this code and it just confused me).

Do we want to have a map event? We used to have one, right?

Reviewing to see if we need to unmap in other places.

Merge request reports