Skip to content

Compositor pointer grab for the focused view (fix #613)

Simon Ser requested to merge github/fork/acrisci/fix-613 into master

Created by: acrisci

Feedback on the approach is appreciated.

Tests:

  • Test drag and drop still works.
  • Test #613 (closed) is fixed.
  • Click on the window and drag outside and make sure the view you clicked on is getting all those motion events outside the surface still.
    • When you release the button, make sure the pointer leaves the surface
    • When you press additional buttons outside the surface, make sure that surface is getting the buttons.
  • Test xwayland decorations work correctly (cursors were broken before)

Compare the behavior to Weston and X11 (because the behaviors are different and Weston still has bugs related to this, but X11 works pretty well).

Open question:

Should we deny popups while the view has a pointer grab?

TODO:

  • style cleanups
  • handle the grabbed view closing during the grab
  • handle management of cursor->grabbed_view a bit better

fixes #613 (closed)

Merge request reports