Thibault Saunier authored 5 years ago and Tim-Philipp Müller committed 5 years ago

And fix paste annotation

Thibault Saunier authored 5 years ago and Tim-Philipp Müller committed 5 years ago

Fixes gstreamer/gst-editing-services#69

This was missing due to a typo.

Alexandru Băluț authored 5 years ago and Thibault Saunier committed 5 years ago

ges_container_add removes the child being added if the call to
ges_timeline_element_set_parent fails. In this case, subclasses should
be given the chance to revert the effects of the add_child vmethod which
has just been called.

Mart Raudsepp authored 5 years ago and Thibault Saunier committed 5 years ago

These are showing up in performance profile of 1000+ clips looped addition.
All this is done at commit time as well, so let that do only one update and
sorting.

The task already has a ref so this one doesn't make sense and leads to leaks

This is just plain broken 19064350
but we can't do anything about it.

Discoverer maintain a referernce on the discoverer object while
the async timeout callback is alive to prevent a potential crash
if the object is freed while the callback is pending.

But if g_main_context is released before calling the timeout callback,
the discoverer pointer which was weak referenced from GESUriClipAssetClass
will not be disposed because the discoverer object is not finalized.