Reset some KMS CRTC properties
Weston does not actually use these KMS properties, but it does expect them to be pass-through in the KMS color pipeline.
Let's ensure they are pass-through.
The VRR property is similar, just ensure it's disabled.
Merge request reports
Activity
added DRM/KMS backend label
assigned to @pq
- Resolved by Pekka Paalanen
636 637 lut = calloc(len, sizeof(uint16_t)); 638 if (!lut) 639 return; 640 641 /* Identity curve */ 642 for (i = 0; i < len; i++) 643 lut[i] = 0xffff * i / (len - 1); 644 645 ret = drmModeCrtcSetGamma(output->device->drm.fd, 646 output->crtc->crtc_id, 647 len, lut, lut, lut); 648 if (ret < 0 && ret != -EOPNOTSUPP && ret != -ENOSYS) { 649 weston_log("%s failed for %s: %s\n", __func__, 650 output->base.name, strerror(-ret)); 651 } That would be a slight abuse of
deprecated_gamma_is_set
, and when the deprecated gamma APIdrm_output_set_gamma()
gets removed,deprecated_gamma_is_set
will be removed as well.I think we need another boolean
legacy_gamma_not_supported
, but what signifies that? BothEOPNOTSUPP
andENOSYS
?
- Resolved by Daniel Stone
added 42 commits
-
e4ad3647...5ffa1962 - 36 commits from branch
wayland:main
- 2a060094 - backend-drm: move *_add_prop() debug earlier
- 4a02723e - backend-drm: reset CRTC_GAMMA_LUT
- 2db8a0ca - backend-drm: reset gamma on legacy KMS
- b34f4bc0 - backend-drm: reset CRTC_DEGAMMA_LUT
- 33c6c6b8 - backend-drm: reset CRTC_CTM
- 9e769872 - backend-drm: reset CRTC_VRR_ENABLED
Toggle commit list-
e4ad3647...5ffa1962 - 36 commits from branch
mentioned in issue #467
@daniels, would you like to take another look?
added 158 commits
-
9e769872...771bd8ac - 152 commits from branch
wayland:main
- f42eb4b4 - backend-drm: move *_add_prop() debug earlier
- 6a606f57 - backend-drm: reset CRTC_GAMMA_LUT
- f23bf2f4 - backend-drm: reset gamma on legacy KMS
- 39ce6b3e - backend-drm: reset CRTC_DEGAMMA_LUT
- 188bfb99 - backend-drm: reset CRTC_CTM
- 008955e3 - backend-drm: reset CRTC_VRR_ENABLED
Toggle commit list-
9e769872...771bd8ac - 152 commits from branch
added 133 commits
-
008955e3...ec27b2a1 - 127 commits from branch
wayland:main
- dbce396c - backend-drm: move *_add_prop() debug earlier
- debfeb30 - backend-drm: reset CRTC_GAMMA_LUT
- 1acf69ac - backend-drm: reset gamma on legacy KMS
- d1ca5f71 - backend-drm: reset CRTC_DEGAMMA_LUT
- e0d267fb - backend-drm: reset CRTC_CTM
- 40999363 - backend-drm: reset CRTC_VRR_ENABLED
Toggle commit list-
008955e3...ec27b2a1 - 127 commits from branch
enabled an automatic merge when the pipeline for 40999363 succeeds