Skip to content
Snippets Groups Projects

pixman-renderer: track Pixman formats in pixel format table

Merged M. Stoeckl requested to merge mstoeckl/weston:pixman-fmts into main
All threads resolved!

Instead of using a hardcoded switch to convert wl_shm formats to Pixman formats, add the Pixman format codes to the pixel format table. This makes it easier to add support for more shm formats when using the Pixman renderer. (Supporting 10-bit shm buffer formats is also a small step towards letting the pixman renderer generate 10-bit deep output.)

I tested this with a variant of the weston-simple-shm client that supports multiple shm buffer formats; see the branch at https://gitlab.freedesktop.org/mstoeckl/weston/-/commits/simple-shm-10 .

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Stone
  • Looks good to me apart from two minor comments, thanks!

  • M. Stoeckl added 1 commit

    added 1 commit

    • fe65a47c - pixman-renderer: track Pixman formats in pixel format table

    Compare with previous version

  • M. Stoeckl added 1 commit

    added 1 commit

    • 873553f6 - pixman-renderer: track Pixman formats in pixel format table

    Compare with previous version

  • Simon Ser resolved all threads

    resolved all threads

  • Simon Ser
  • M. Stoeckl added 1 commit

    added 1 commit

    • 5ff00e96 - pixman-renderer: track Pixman formats in pixel format table

    Compare with previous version

  • Daniel Stone
  • M. Stoeckl added 1 commit

    added 1 commit

    • 8ab05c76 - pixman-renderer: track Pixman formats in pixel format table

    Compare with previous version

  • Daniel Stone resolved all threads

    resolved all threads

  • Yeah, looks good. Let's leave this for a couple of days and see if there are any more comments.

  • LGTM as well

  • Marius Vlad added 53 commits

    added 53 commits

    Compare with previous version

  • Marius Vlad enabled an automatic merge when the pipeline for 8a7f1e2b succeeds

    enabled an automatic merge when the pipeline for 8a7f1e2b succeeds

  • Everyone seems to be happy about this, rebased and did two small function indents. Merging when CI finishes with it.

  • merged

  • Please register or sign in to reply
    Loading