Skip to content

clients/simple-egl: Allow more EGL configs to be used

Robert Mader requested to merge rmader/weston:simple-egl-tweaks into master

This attempts to make the simple-egl client to be more useful to me as a compositor and app developer.

  1. Choose first matching EGL config instead of requiring 32bit

This effectively makes us use a XRGB2101010 visual when requesting an opaque config and presumably matches the normal bahivour of applications that are not hardcoded to 32bit. In order to make sure to not regress the alpha case, request at least 8bit alpha. As Wayland compositors are required to support A8888 visuals, we can be sure to get at least a 32bit visual as previously - however, 40/48bit visuals should also get accepted now.

  1. Do not set an opaque region

If opaqueness is actively requested, the driver and compositor should make sure we are recognised as opaque. This allowed me to spot a bug in Mutter, which didn't handle the XRGB2101010 case correctly. Setting the opaque region in this case is IMHO a bad idea for several reasons: it may push developers to copy this behaviour, increasing complexety for them, while making it harder for compositor and driver devs to spot bugs on their side.

Also remove the opaque region for the fullscreen case - we already have the -o option to request that, so there doesn't appear to be a reason to not allow a transparet fullscreen windows to be tested.

Signed-off-by: Robert Mader robert.mader@posteo.de


See also:

Edited by Robert Mader

Merge request reports