Skip to content

Clean up use of frame_signal

Leandro Ribeiro requested to merge leandrohrb/weston:cleanup_framesignal into master

This is an effort to eliminate previous_damage from weston_output, although we still have to decide what to do with output->previous_damage usage in DRM backend.

  • 1/6. Move the frame_signal emission to weston_output_repaint(), what makes the code easier to follow and avoids duplication. This should have no observable effects.
  • 2/6 and 3/6. For users that are listening to frame_signal and rely on void *data parameter to be a pointer to weston_output, add weston_output member to their private data structs. This way we can make previous_damage to be given using this data parameter.
  • 4/6. Change the frame_signal emit call to pass damage region as the data argument.
  • 5/6 and 6/6. Change the frame_signal users of output->previous_damage to instead get the damage from the data argument.

Fixes: #256 (closed)

Edited by Leandro Ribeiro

Merge request reports