Deprecate and remove the fbdev backend
The fbdev uAPI is deprecated. There are better alternatives kernel-wide (e.g. tinydrm and simpledrm).
Ref #477 (comment 832714), cc @n3rdopolis
Activity
I agree.
Following the suggested process in #477, could we rush in the "are you really sure you want to build fbdev" nagging for Weston 10.0.0 or is it too late?
!764 (merged) implements this.
added fbdev backend label
-
I tried this in 2019 and only @n3rdopolis wanted it to stay back then.
Thanks for the heads up. Since SimpleDRM got merged, (I still have to compile the kernel because Debian doesn't build it yet) I no longer am going to complain about the fbdev backend going away.
I think the PostMarketOS folks might use it though, although they might be able to use SimpleDRM too (on non x86 platforms? I think)
mentioned in commit emersion/weston@d25c29cc
mentioned in merge request !764 (merged)
mentioned in commit emersion/weston@c44ddf57
mentioned in commit emersion/weston@9e3c1e3f
mentioned in commit emersion/weston@6338dbd5
Seriously, dropping fbdev? Arch just updated to 10.0.0 and now my local spi connected screen no longer works with weston. I have tried the other backends and I get nothing. Are there other flags in the weston.ini that are required to get it to work? I've tried drm and it errors out. This is on arch linux arm running on a RPi v3/4. Used to work under armv7 and aarch64. It still works with X11... The screen is the AdaFruit PiTFT Plus - 3.5" Resistive touch-screen. The log when started with weston 9 is:
[20:57:54.640] weston 9.0.0 https://wayland.freedesktop.org Bug reports to: https://gitlab.freedesktop.org/wayland/weston/issues/ Build: 9.0.0 [20:57:54.640] Command line: /usr/bin/weston --tty=1 --log=/var/log/weston.log --config=/srv/http/.config/weston.ini --modules=systemd-notify.so [20:57:54.640] OS: Linux, 5.15.21-3-rpi-ARCH, #1 SMP PREEMPT Fri Feb 11 13:59:13 UTC 2022, aarch64 [20:57:54.641] Using config file '/srv/http/.config/weston.ini' [20:57:54.641] Output repaint window is 7 ms maximum. [20:57:54.641] Loading module '/usr/lib/libweston-9/fbdev-backend.so' [20:57:54.648] initializing fbdev backend [20:57:54.654] logind: not running in a systemd session [20:57:54.654] logind: cannot setup systemd-logind helper (-61), using legacy fallback [20:57:54.654] Opening fbdev frame buffer. [20:57:54.654] Calculating pixman format from: - type: 0 (aux: 0) - visual: 2 - bpp: 16 (grayscale: 0) - red: offset: 11, length: 5, MSB: 0 - green: offset: 5, length: 6, MSB: 0 - blue: offset: 0, length: 5, MSB: 0 - transp: offset: 0, length: 0, MSB: 0 [20:57:54.654] Created head 'fbdev' for device /dev/fb1 (fb_hx8357d) [20:57:54.671] event0 - stmpe-ts: is tagged by udev as: Touchscreen [20:57:54.673] event0 - stmpe-ts: device is a touch device [20:57:54.674] event0 - stmpe-ts: applying calibration: 0.004628 1.099945 -0.038703 -1.114836 0.016171 1.047997 [20:57:54.677] event1 - Jabra Evolve2 65 (AVRCP): is tagged by udev as: Keyboard [20:57:54.677] event1 - Jabra Evolve2 65 (AVRCP): device is a keyboard [20:57:54.678] Touchscreen - stmpe-ts - /sys/devices/platform/soc/3f204000.spi/spi_master/spi0/spi0.1/stmpe-ts/input/input0/event0 [20:57:54.678] libinput: configuring device "stmpe-ts". [20:57:54.713] libinput: configuring device "Jabra Evolve2 65 (AVRCP)". [20:57:54.713] Creating fbdev output. [20:57:54.713] Opening fbdev frame buffer. [20:57:54.713] Calculating pixman format from: - type: 0 (aux: 0) - visual: 2 - bpp: 16 (grayscale: 0) - red: offset: 11, length: 5, MSB: 0 - green: offset: 5, length: 6, MSB: 0 - blue: offset: 0, length: 5, MSB: 0 - transp: offset: 0, length: 0, MSB: 0 [20:57:54.713] Mapping fbdev frame buffer. [20:57:54.713] fbdev output 480×320 px guessing 60 Hz and 96 dpi [20:57:54.713] associating input device event0 with output fbdev (none by udev) [20:57:54.713] associating input device event1 with output fbdev (none by udev) [20:57:54.713] Output 'fbdev' enabled with head(s) fbdev [20:57:54.713] Compositor capabilities: arbitrary surface rotation: yes screen capture uses y-flip: no presentation clock: CLOCK_MONOTONIC_RAW, id 4 presentation clock resolution: 0.000000001 s [20:57:54.714] Loading module '/usr/lib/weston/kiosk-shell.so' [20:57:54.715] Loading module '/usr/lib/weston/systemd-notify.so'Edited by gearhead
This is on arch linux arm running on a RPi v3/4
Have you tried the DRM-backend? Replace
fbdev-backend.sow/drm-backend.soin the ini config file. If you get an error about it, check if you have the correct device nodes under/dev/dri/. Probably you don't have DRM driver loaded. Don't know about RPi3, but RPi4 should definitely work.FWIW, here's the DRM driver for that panel: https://cgit.freedesktop.org/drm-tip/tree/drivers/gpu/drm/tiny/hx8357d.c
-
Yes, seriously. At this very moment there is active work done in the kernel to allow converting even the last fbdev drivers to DRM.
Still, the fbdev-backend is not gone yet in Weston 10 series. You can still enable it in the build. We wanted to make people really notice that the fbdev-backend is going to go away before it actually disappears, that is why you have you change your build options now if you want to keep on using it a little further.
So, this old dog needs to learn a new trick... If I could ask for help getting this going, I'd appreciate it. If this is not the place, please let me know. The fb driver is loaded:
# lsmod | grep hx fb_hx8357d 16384 1 fbtft 45056 1 fb_hx8357dWeston starts without issue but nothing shows up on the screen.
Date: 2022-02-17 CST [08:16:52.152] weston 10.0.0 https://wayland.freedesktop.org Bug reports to: https://gitlab.freedesktop.org/wayland/weston/issues/ Build: 10.0.0 [08:16:52.152] Command line: /usr/bin/weston --tty=1 --log=/var/log/runeaudio/weston.log --config=/srv/http/.config/weston.ini --modules=systemd-notify.so [08:16:52.152] OS: Linux, 5.15.23-1-rpi-ARCH, #1 SMP PREEMPT Wed Feb 16 18:04:14 UTC 2022, aarch64 [08:16:52.152] Flight recorder: enabled [08:16:52.153] Using config file '/srv/http/.config/weston.ini' [08:16:52.164] Output repaint window is 7 ms maximum. [08:16:52.166] Loading module '/usr/lib/libweston-10/drm-backend.so' [08:16:52.184] initializing drm backend [08:16:52.184] Trying logind launcher... [08:16:52.184] logind: cannot find systemd session for uid: 0 -61 [08:16:52.184] logind: cannot setup systemd-logind helper error: (No data available), using legacy fallback [08:16:52.184] Trying weston_launch launcher... [08:16:52.184] could not get launcher fd from env [08:16:52.184] Trying direct launcher... [08:16:52.190] using /dev/dri/card0I am guessing that the /dev/dri/card0 is the HDMI output
# ls /dev/dri by-path card0 renderD128how do I get the spi connected display to use the drm backend?
Edited by gearhead-
Instead of building the kernel with
FB_TFT_HX8357Duse/selectTINYDRM_HX8357D-- as shown up by @emersion above. Kernel should probe it at boot/load-up, or just enable the tinydrm one and blacklist the fbdev driver at boot-up. If rebuilding the kernel is too inconvenient, you can try rebuilding weston itself, as @pq mentioned, by appending-Ddeprecated-backend-fbdev=trueto your meson build flags. I now have a tinydrm driver built for the hx8357d but cannot figure out how to use it.
# modprobe hx8357d # lsmod | grep hx hx8357d 16384 0 drm_mipi_dbi 28672 1 hx8357d drm_kms_helper 278528 5 hx8357d,vc4,drm_mipi_dbi drm 552960 6 hx8357d,drm_kms_helper,vc4,drm_mipi_dbiWhen I ls /dev/dri, all that is there is the hdmi.
ls -al /dev/dri total 0 drwxr-xr-x 3 root root 100 Feb 10 13:19 . drwxr-xr-x 19 root root 3660 Feb 17 18:38 .. drwxr-xr-x 2 root root 80 Feb 17 18:37 by-path crw-rw---- 1 root video 226, 0 Feb 17 18:37 card0 crw-rw-rw- 1 root render 226, 128 Feb 10 13:19 renderD128I can get weston to start and run on weston-1 which is the hdmi and it is fine. How do I get weston to launch on the small screen? It does not seem like it is 'activated' as it is white. Usually when it is detected and ready, it is dark. I have not figured out how to set it up with a dtoverlay, yet, either.
-
compatible = "himax,hx8357d", "adafruit,yx350hv15";Which seems to be in pitft35-resistive overlay (from rpi kernel). Add something like
dtoverlay=pitft35-resistive,rotate=90,fps=60in
/boot/config.txtand see if that brings it up.Some further docs that might help:
@mvlad Thanks for the help! I had not seen that gentoo page. With info there plus a bit of experimentation, I was able to get something going. To do so, I had to blacklist fb_hx8357d and add hx8357d to /etc/modules-load.d/drm-display.conf to get it to load at boot. With this plus the lines in the config.txt, I was able to get X11 to display and the touch screen works but weston is rotated 90 deg and no amount of futzing with the weston.ini seems to have any effect. I do not yet understand the hdmi output config lines. It seems that the dtoverlay line (which is what I used with the framebuffer driver) is not being read as it is not rotating the display there.
dtparam=i2c_arm=on dtparam=spi=on dtoverlay=pitft35-resistive,rotate=90,speed=32000000,fps=20 gpu_mem=128 dtoverlay=vc4-fkms-v3d ## configuring HDMI output hdmi_force_hotplug=0 hdmi_group=2 hdmi_mode=87 hdmi_cvt=320 240 60 1 0 0 0 max_framebuffers=1it is being loaded
# lsmod | grep hx hx8357d 16384 4 drm_mipi_dbi 28672 1 hx8357d drm_kms_helper 278528 6 hx8357d,vc4,drm_mipi_dbi drm 552960 13 hx8357d,drm_kms_helper,vc4,drm_mipi_dbiThis is how it comes up in dmesg:
# dmesg | grep 'hx\|drm' [ 5.678384] [drm] Initialized hx8357d 1.0.0 20181023 for spi0.0 on minor 0 [ 13.686495] hx8357d spi0.0: [drm] fb1: hx8357ddrmfb frame buffer device [ 20.278345] vc4-drm soc:gpu: bound 3f600000.firmwarekms (ops vc4_fkms_ops [vc4]) [ 20.278499] vc4-drm soc:gpu: bound 3fc00000.v3d (ops vc4_v3d_ops [vc4]) [ 20.279364] [drm] Initialized vc4 0.0.0 20140616 for soc:gpu on minor 1 [ 20.300357] vc4-drm soc:gpu: [drm] fb0: vc4drmfb frame buffer deviceThere is not another /dev/dri listing but I guess that is normal. When I start weston, though, it starts on WL1 and now I cannot get it to rotate. but weston does start and it seems to work with the drm backend. I do think that I'll need to write a new dtoverlay, though to load the proper module and not fb_hx8357d. I looked through the code listings and am still a bit lost on that. Right now, it is rotated 90 degrees and has a black bar at the side and am trying to get that resolved, first. Any ideas?
-
Any ideas?
Try the
transformoption for the output: https://gitlab.freedesktop.org/wayland/weston/-/blob/main/man/weston-drm.man#L119 I tried just a number as the rotate value, '270' and 'rotate-270' and it will not rotate from portrait mode.
[output] name=WL1 mode=current #transform=normal transform=rotate-270 scale=1The log is as follows:
Date: 2022-02-19 CST [13:20:28.977] weston 10.0.0 https://wayland.freedesktop.org Bug reports to: https://gitlab.freedesktop.org/wayland/weston/issues/ Build: 10.0.0 [13:20:28.977] Command line: /usr/bin/weston --tty=1 --log=/var/log/runeaudio/weston.log --config=/srv/http/.config/weston.ini --modules=systemd-notify.so [13:20:28.977] OS: Linux, 5.15.23-1-rpi-ARCH, #1 SMP PREEMPT Thu Feb 17 14:21:39 CST 2022, aarch64 [13:20:28.977] Flight recorder: enabled [13:20:28.977] Using config file '/srv/http/.config/weston.ini' [13:20:28.988] Output repaint window is 7 ms maximum. [13:20:28.990] Loading module '/usr/lib/libweston-10/drm-backend.so' [13:20:29.007] initializing drm backend [13:20:29.008] Trying logind launcher... [13:20:29.008] logind: cannot find systemd session for uid: 0 -61 [13:20:29.008] logind: cannot setup systemd-logind helper error: (No data available), using legacy fallback [13:20:29.008] Trying weston_launch launcher... [13:20:29.008] could not get launcher fd from env [13:20:29.008] Trying direct launcher... [13:20:29.015] using /dev/dri/card0 [13:20:29.015] DRM: supports atomic modesetting [13:20:29.015] DRM: supports GBM modifiers [13:20:29.015] DRM: supports picture aspect ratio [13:20:29.017] Loading module '/usr/lib/libweston-10/gl-renderer.so' [13:20:31.401] EGL client extensions: EGL_EXT_device_base EGL_EXT_device_enumeration EGL_EXT_device_query EGL_EXT_platform_base EGL_KHR_client_get_all_proc_addresses EGL_EXT_client_extensions EGL_KHR_debug EGL_EXT_platform_device EGL_EXT_platform_wayland EGL_KHR_platform_wayland EGL_EXT_platform_x11 EGL_KHR_platform_x11 EGL_MESA_platform_xcb EGL_MESA_platform_gbm EGL_KHR_platform_gbm EGL_MESA_platform_surfaceless [13:20:31.404] EGL device extensions: EGL_EXT_device_drm [13:20:31.404] EGL version: 1.4 [13:20:31.404] EGL vendor: Mesa Project [13:20:31.404] EGL client APIs: OpenGL OpenGL_ES [13:20:31.404] EGL extensions: EGL_ANDROID_blob_cache EGL_ANDROID_native_fence_sync EGL_EXT_buffer_age EGL_EXT_image_dma_buf_import EGL_EXT_image_dma_buf_import_modifiers EGL_KHR_cl_event2 EGL_KHR_config_attribs EGL_KHR_create_context EGL_KHR_create_context_no_error EGL_KHR_fence_sync EGL_KHR_get_all_proc_addresses EGL_KHR_gl_colorspace EGL_KHR_gl_renderbuffer_image EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_3D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_no_config_context EGL_KHR_reusable_sync EGL_KHR_surfaceless_context EGL_EXT_pixel_format_float EGL_KHR_wait_sync EGL_MESA_configless_context EGL_MESA_drm_image EGL_MESA_image_dma_buf_export EGL_MESA_query_driver EGL_WL_bind_wayland_display [13:20:31.405] EGL_KHR_surfaceless_context available [13:20:31.496] GL version: OpenGL ES 2.0 Mesa 21.3.6 [13:20:31.496] GLSL version: OpenGL ES GLSL ES 1.0.16 [13:20:31.496] GL vendor: Broadcom [13:20:31.496] GL renderer: VC4 V3D 2.1 [13:20:31.496] GL extensions: GL_EXT_blend_minmax GL_EXT_multi_draw_arrays GL_EXT_texture_format_BGRA8888 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth24 GL_OES_element_index_uint GL_OES_fbo_render_mipmap GL_OES_mapbuffer GL_OES_rgb8_rgba8 GL_OES_stencil8 GL_OES_texture_3D GL_OES_texture_npot GL_OES_vertex_half_float GL_OES_EGL_image GL_OES_depth_texture GL_AMD_performance_monitor GL_OES_packed_depth_stencil GL_OES_get_program_binary GL_APPLE_texture_max_level GL_EXT_discard_framebuffer GL_EXT_read_format_bgra GL_EXT_frag_depth GL_NV_fbo_color_attachments GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_vertex_array_object GL_ANGLE_pack_reverse_row_order GL_EXT_occlusion_query_boolean GL_EXT_unpack_subimage GL_NV_draw_buffers GL_NV_read_buffer GL_NV_read_depth GL_NV_read_depth_stencil GL_NV_read_stencil GL_EXT_draw_buffers GL_EXT_map_buffer_range GL_KHR_debug GL_KHR_texture_compression_astc_ldr GL_NV_pixel_buffer_object GL_OES_required_internalformat GL_OES_surfaceless_context GL_EXT_separate_shader_objects GL_EXT_compressed_ETC1_RGB8_sub_texture GL_EXT_draw_elements_base_vertex GL_EXT_texture_border_clamp GL_KHR_context_flush_control GL_OES_draw_elements_base_vertex GL_OES_texture_border_clamp GL_KHR_no_error GL_KHR_texture_compression_astc_sliced_3d GL_KHR_parallel_shader_compile GL_MESA_tile_raster_order GL_MESA_bgra [13:20:31.643] GL ES 2.0 - renderer features: read-back format: BGRA EGL Wayland extension: yes [13:20:31.702] event0 - stmpe-ts: is tagged by udev as: Touchscreen [13:20:31.704] event0 - stmpe-ts: device is a touch device [13:20:31.704] event0 - stmpe-ts: applying calibration: 0.004628 1.099945 -0.038703 -1.114836 0.016171 1.047997 [13:20:31.706] event1 - Jabra Evolve2 65 (AVRCP): is tagged by udev as: Keyboard [13:20:31.706] event1 - Jabra Evolve2 65 (AVRCP): device is a keyboard [13:20:31.707] Touchscreen - stmpe-ts - /sys/devices/platform/soc/3f204000.spi/spi_master/spi0/spi0.1/stmpe-ts/input/input0/event0 [13:20:31.707] libinput: configuring device "stmpe-ts". [13:20:31.778] libinput: configuring device "Jabra Evolve2 65 (AVRCP)". [13:20:31.778] DRM: head 'UNNAMED-1' updated, connector 31 is connected, EDID make 'unknown', model 'unknown', serial 'unknown' [13:20:31.779] DRM: head 'UNNAMED-1' found, connector 31 is connected, EDID make 'unknown', model 'unknown', serial 'unknown' [13:20:31.779] Registered plugin API 'weston_drm_output_api_v1' of size 24 [13:20:31.779] Registered plugin API 'weston_drm_virtual_output_api_v1' of size 48 [13:20:31.779] Color manager: no-op [13:20:31.779] Output 'UNNAMED-1' using color profile: built-in default sRGB SDR profile [13:20:31.780] Chosen EGL config details: id: 7 rgba: 8 8 8 0 buf: 24 dep: 0 stcl: 0 int: 1-1 type: win vis_id: XRGB8888 (0x34325258) [13:20:31.780] Output UNNAMED-1 (crtc 34) video modes: 320x480@0.0, preferred, current, 0.0 MHz [13:20:31.780] associating input device event0 with output UNNAMED-1 (none by udev) [13:20:31.780] associating input device event1 with output UNNAMED-1 (none by udev) [13:20:31.780] Output 'UNNAMED-1' enabled with head(s) UNNAMED-1 [13:20:31.780] Compositor capabilities: arbitrary surface rotation: yes screen capture uses y-flip: yes cursor planes: yes arbitrary resolutions: no view mask clipping: yes explicit sync: yes color operations: no presentation clock: CLOCK_MONOTONIC, id 1 presentation clock resolution: 0.000000001 s [13:20:31.784] Loading module '/usr/lib/weston/kiosk-shell.so' [13:20:31.791] Note: support for the deprecated wl_shell interface is disabled. If a legacy client still needs it, it can be re-enabled by passing -Ddeprecated-wl-shell=true to Meson when building Weston. [13:20:31.793] Loading module '/usr/lib/weston/systemd-notify.so' [13:20:32.527] Warning: computed repaint delay is insane: 1116 msecMy weston.ini
[core] shell=kiosk-shell.so #xwayland=true #modules= backend=/usr/lib/libweston-10/drm-backend.so #repaint-window=7 #gbm-format=xrgb8888 idle-time=0 #require-input=true [libinput] #enable_tap=true #touchscreen_calibrator=true #calibration_helper=/bin/echo [shell] [launcher] [output] mode=320x480 #transform=normal transform=rotate-270 scale=1 [input-method] path=/usr/lib/weston/weston-keyboard [keyboard] keymap_model=pc105 keymap_layout=us vt-switching=true [terminal] [xwayland] [screen-share]Edited by gearhead-
I suspect that rotate doesn't work with
dtoverlaybecause the driver is using "rotation" as property, and not "rotate".https://cgit.freedesktop.org/drm-tip/tree/drivers/gpu/drm/tiny/hx8357d.c#n243
Edit that line above, and s/rotation/rotate for the second parameter. Anything than 0 should return an err, you check, and printk if it did not found it. Otherwise, rebuild it and give it a try.
For weston it is because the output is called 'UNNAMED-1'. Change
WL1toUNNAMED-1.[output] name=UNNAMED-1 transform=rotate-270 I appreciate your help on this. I was able to get the rotation to work without editing and rebuilding the module. Apparently the order of overlays in the config.txt is important. Then I list the 'vc4-kms-v3d' ahead of 'pitft-resistive' second, I can use the directive in weston.ini to rotate the screen and it works as expected, no re-building of the module needed.
gpu_mem=128 dtoverlay=vc4-kms-v3d # configuring HDMI output hdmi_force_hotplug=0 hdmi_group=2 hdmi_mode=87 hdmi_cvt=320 480 60 1 0 0 0 max_framebuffers=1 dtparam=i2c_arm=on dtparam=spi=on dtoverlay=pitft35-resistive,rotate=90,speed=32000000,fps=20The problem I am still struggling with is that the 'pitft-resistive' dtoverlay, regardless of where in the config.txt it is forces the load of the framebuffer module:
# lsmod | grep hx fb_hx8357d 16384 1 fbtft 45056 1 fb_hx8357dunless I blacklist the fb_hx8357d and force the loading of hx8357d, then I get the proper modules:
# lsmod | grep hx hx8357d 16384 1 drm_mipi_dbi 28672 1 hx8357d drm_kms_helper 278528 6 hx8357d,vc4,drm_mipi_dbi drm 552960 5 hx8357d,drm_kms_helper,vc4,drm_mipi_dbiand weston loads and runs.
What I would like to do is make an overlay that loads the proper
hx8357dmodule and notfb_hx8357difvc4-kms-v3dis loaded. Either that or another workaround to force it to not load fb_* modules but * modules only. I have read a lot on it today and cannot find any concise info I can act on.as a note, my small spi display has a dri module recently added to the RPi kernel and the overlay has been patched to load the proper driver. There is no longer an impediment to using the vc4 video core which enables the weston drm backend for the newer RPis, at least for this screen and others which use the hx8357d driver.
mentioned in commit pq/weston@b3ba1bec
mentioned in merge request !812 (merged)
-
I opened !812 (merged) to delete the fbdev backend.
closed with commit b3ba1bec
mentioned in commit NaveenKumar/weston@b16d33a2
mentioned in commit NaveenKumar/weston@c648a012
