Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • W weston
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 341
    • Issues 341
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 131
    • Merge requests 131
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • waylandwayland
  • weston
  • Issues
  • #310
Closed
Open
Issue created Nov 21, 2019 by Pekka Paalanen@pqMaintainer

Run subsurface-shot test with GL-renderer

While developing !287 (merged) I noticed that the subsurface-shot test does not pass if trivially ran with GL-renderer. That is because the background color is defined in floats. That is converted to uint8 by truncation in Pixman-renderer and by rounding in GL-renderer. This causes the reference image created with Pixman-renderer to differ from what GL-renderer produces.

If the theory holds, we need to allow a +1 fuzz in the color values when comparing to reference. That should work when the reference image and the test image have the same bit-depth regardless of what it is.

Implement the fuzz and make subsurface-shot run on both Pixman- and GL-renderers.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking