Skip to content
  • Leandro Ribeiro's avatar
    8b0c2e31
    drm: do not pull writeback task if KMS atomic API is not supported · 8b0c2e31
    Leandro Ribeiro authored and Marius Vlad's avatar Marius Vlad committed
    
    
    Since 2d70bdfd "drm-backend: add support
    to output capture writeback source", the DRM-backend was broken for KMS
    devices that do not support the atomic API. This fixes that.
    
    We don't support writeback screenshots without atomic modeset support.
    So for such devices, we never update the output capture info
    (weston_output_update_capture_info()) for the writeback source.
    
    The function that we use to pull writeback tasks
    (weston_output_pull_capture_task()) asserts that the capture providers
    (renderers, DRM-backend) did not forget to update the capture info
    (size/format) if something changed. But as we've never updated the
    capture info for such devices, it is zeroed, leading to an assert hit.
    
    With this patch we only pull the capture task for KMS devices that
    support the atomic API.
    
    Signed-off-by: default avatarLeandro Ribeiro <leandro.ribeiro@collabora.com>
    (cherry picked from commit 32264175)
    8b0c2e31
    drm: do not pull writeback task if KMS atomic API is not supported
    Leandro Ribeiro authored and Marius Vlad's avatar Marius Vlad committed
    
    
    Since 2d70bdfd "drm-backend: add support
    to output capture writeback source", the DRM-backend was broken for KMS
    devices that do not support the atomic API. This fixes that.
    
    We don't support writeback screenshots without atomic modeset support.
    So for such devices, we never update the output capture info
    (weston_output_update_capture_info()) for the writeback source.
    
    The function that we use to pull writeback tasks
    (weston_output_pull_capture_task()) asserts that the capture providers
    (renderers, DRM-backend) did not forget to update the capture info
    (size/format) if something changed. But as we've never updated the
    capture info for such devices, it is zeroed, leading to an assert hit.
    
    With this patch we only pull the capture task for KMS devices that
    support the atomic API.
    
    Signed-off-by: default avatarLeandro Ribeiro <leandro.ribeiro@collabora.com>
    (cherry picked from commit 32264175)
Loading