Skip to content

protocol: Undefine wl_display_sync callback data

Colin Kinloch requested to merge ColinKinloch/wayland:wl_display_sync_no_data into main

I think the callback data for wl_display_sync should either explicitly be ignored or better defined.
Does it refer to a new serial for the callback or the last event serial?
Is there a good usecase for it?

The implementation seems not to be consistent across compositors:

  • mutter - starts at a high number and increments without an event
  • weston - serial of previous event
  • kwin - serial of previous event
  • anvil - always 0

This is because the implementation gets the signal without incrementing it: https://gitlab.freedesktop.org/wayland/wayland/-/blob/c5d145a602581ee70f3ee87566ccb5cf1ff6cce8/src/wayland-server.c?page=2#L1043

Edited by Colin Kinloch

Merge request reports