Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • W wayland-protocols
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 56
    • Merge requests 56
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • waylandwayland
  • wayland-protocols
  • Merge requests
  • !171

xdg-shell: Add xdg_popup.set_parent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Vlad Zahorodnii requested to merge zzag/wayland-protocols:work/zzag/xdg-popup-set-parent into main Nov 01, 2022
  • Overview 8
  • Commits 1
  • Pipelines 2
  • Changes 1

This is meant to make it easier for toolkits to provide interoperability measures between xdg_popup surfaces and non xdg_surface popup parents, e.g. layer_surface_v1.

The existing mechanism to specify the parent surface using "some other protocol" breaks encapsulation as creating a child window requires actions to be performed on the parent window, requiring client code for the child popup window to be aware of the parent types.

Even if that is papered out, we will end up with divergent code paths for presenting popups in toolkits, which breaks encapsulation and becomes major blocker for shipping out-of-tree custom shell plugins.

Signed-off-by: Vlad Zahorodnii vlad.zahorodnii@kde.org

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/zzag/xdg-popup-set-parent