Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • W wayland-protocols
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 56
    • Merge requests 56
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • waylandwayland
  • wayland-protocols
  • Merge requests
  • !167

xdg-shell: Relax popup destroy order requirements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kenny Levinsen requested to merge kennylevinsen/wayland-protocols:popup-unordered-destroy into main Oct 18, 2022
  • Overview 7
  • Commits 1
  • Pipelines 1
  • Changes 1

Calling destroy on any popup other than the topmost popup associated with the given toplevel is currently a protocol error. As younger popups stack on top of older popups, this means that an older popup cannot be destroyed before a younger one.

This requirements conflicts with legitimate use-cases, such as having an older tooltip disappear after a newer tooltip has opened, or dismissing a context menu after a popup-based notification has appeared.

Relax the destroy requirements to allow out-of-order popup destruction.

Signed-off-by: Kenny Levinsen kl@kl.wtf

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: popup-unordered-destroy