Skip to content

text-input: Add on_screen_input_provided hint (v2)

This is the second attempt at making sure that input method's virtual keyboard doesn't show up unnecessarily. I've changed the field name compared to v1 (on the mailing list) in order to make it clear that a visual element is unneeded.

I intend this to be matched on the zwp_input_method side, and let the input method itself decide whether what it wants displayed. Perhaps an input method has visual elements that are not keyboard-like, e.g. a suggestion box. The compositor will always be able to override this decision anyway.

Can be tested with GTK:

Gtk: https://gitlab.gnome.org/dcz/gtk/tree/inhibit_osk

Text input client (tests/entry.py) and input method provider (squeekboard): https://source.puri.sm/dorota.czaplejewicz/squeekboard/-/commits/purpose_input

Compositor (phoc): https://source.puri.sm/Librem5/phoc/

When run in such a setup, it's not very spectacular: phoc passes the hint flags from the client to the input method, and the input method complains that it doesn't understand with Warning: received invalid hint flags. While not very graceful, the values do indeed get all the way through the stack.

If this gets approved, I will include the corresponding change in the incoming input_method revision.

Edited by Dorota Czaplejewicz (Purism)

Merge request reports

Loading