Skip to content
Snippets Groups Projects
Commit 4f8ddf4e authored by Matthew Waters's avatar Matthew Waters :koala: Committed by Vivia Nikolaidou
Browse files

wpesrc: replace object lock usage with a new lock

Using the object lock is problematic for anything that can dispatch to
another thread which is what createWPEView() does inside
gst_wpe_src_start().  Using the object lock there can cause a deadlock.

One example of such a deadlock is when createWPEView is called, but
another (or the same) wpesrc is on the WPEContextThread and e.g. posts a
bus message.  This message propagations takes and releases the object
lock of numerous elements in quick succession for determining various
information about the elements in the bin.  If the object lock is
already held, then the message propagation will block and stall bin
processing (state changes, other messages) and wpe servicing any events.

Fixes gstreamer/gst-plugins-bad#1490

Part-of: <gstreamer/gst-plugins-bad!1934>
parent 04b9d1d7
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment