Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 78
    • Issues 78
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !830

Revert two shader layout changes to fix regressed dEQP tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ryan Neph requested to merge ryanneph/virglrenderer:revert-shader-layout into master Jun 15, 2022
  • Overview 3
  • Commits 2
  • Pipelines 4
  • Changes 1

Reverts two commits to fix the regressed dEQP tests described #266 (closed):

c5f118c8ff1 2022-06-02 shader: Remove layout_location field         [needed to fix the build after previous revert]
99f8cd3dc0c 2022-05-26 shader: remove obsolete layout handling code [bisection flagged as the cause of regression]

If we can't arrive at a solution to #266 (closed), I'd request landing this revert to fix the tests in the meantime.

/cc @gerddie @zzyiwei @chadversary

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: revert-shader-layout