Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 78
    • Issues 78
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !814

debug: Introduce "strict" build option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open 小田喜陽彦 requested to merge akihiko.odaki/virglrenderer:debug-abort-on-warnings-on-ci into master May 22, 2022
  • Overview 8
  • Commits 4
  • Pipelines 44
  • Changes 14

virglrenderer is permissive for errors and it often emits messages with vrend_printf() in an abnormal situation. The behavior is preferrable for real use, but not for testing.

The new "strict" build option introduces alternative behaviors effective to catch such errors in the following two situations:

  • When the guest issues invalid commands. Such guest errors are now trapped with report_guest_errorf() in vrend_renderer.c or warnf() in vrend_shader.c and invalidates the context in "strict" build.
  • When the host encounters unexpected but non-fatal internal errors. In such a case, vrend_printf() is replaced with vrend_unhandled_warnf(), which aborts after logging in "strict" build.

The earlier commits fix some problems detected with this change.

Signed-off-by: Akihiko Odaki akihiko.odaki@gmail.com

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: debug-abort-on-warnings-on-ci