Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 73
    • Issues 73
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !774

vrend: Add comments to some obscure operations on vrend_renderer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Igor Torrente requested to merge igor.torrente/virglrenderer:flaky into master Apr 01, 2022
  • Overview 9
  • Commits 1
  • Pipelines 8
  • Changes 2

vrend_sampler_view_reference, vrend_shader_state_reference and vrend_resource_reference have some obscure address calculation that cause confusion for some that don't fully understand what is happening there.

Adds new comments to explain what is happening in these codes and why we aren't really de-referencing any NULL pointer.

Signed-off-by: Igor Torrente igor.torrente@collabora.com

Edited Apr 06, 2022 by Igor Torrente
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: flaky