Skip to content

vrend: partial revert to fix bgra sampling regression

Ryan Neph requested to merge ryanneph/virglrenderer:fix-bgra-sampler into master

Backtracks on one change from commit 5304e7d3 ("vrend: add vrend_resource_needs_redblue_swizzle() to fix arcvm deqp"), that incorrectly inverted the behavior for setting swizzle parameters for a sampler of eglimage-backed bgra resources.

Fixes: 5304e7d3 ("vrend: add vrend_resource_needs_redblue_swizzle() to fix arcvm deqp") Signed-off-by: Ryan Neph ryanneph@google.com

/cc @gerddie This is a condition that dEQP doesn't cover so it slipped through last week when I published 5304e7d3 to fix one test. The logic for this case is odd, because when creating a sampler, we actually do use a view intentionally with the wrong internalformat and then fix the swizzle parameters if necessary. In my most recent change, I inverted that logic by mistake. This commit simply reverts that one condition.

Merge request reports