Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 86
    • Issues 86
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !740

vrend: add vrend_resource_needs_redblue_swizzle() to fix arcvm deqp

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ryan Neph requested to merge ryanneph/virglrenderer:fix-rgb888 into master Mar 11, 2022
  • Overview 3
  • Commits 1
  • Pipelines 10
  • Changes 1

Fixes dEQP-EGL.functional.wide_color#window_888_colorspace_srgb on ARCVM, which uses a 24 bit-per-pixel R8G8B8_UNORM surface format that slipped through the cracks during the latest BGRA rework in !725 (merged).

Fixes: 187e6513 ("vrend: avoid srgb views on eglimage-backed surfaces")


This also clarifies the special cases a bit better by adding a new helper bool vrend_resource_needs_redblue_swizzle(res, view_format);.

I'm running the full dEQP suite on ARCVM now; will notify here when it finishes.

/cc @lepton @gerddie

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-rgb888