venus: minor refactor

Improves the vkr_context_create error handling code for a cleaner code.

@tomeu @rakko

This file is generated from venus-protocol, right?

If so, any change to these files should happen in that repo, either in the input data files, or the scripts that generate them.

But if the file is generated, then it probably doesn't matter any changes that make it easier to modify, as they aren't expected to be modified directly.

Maybe I'm wrong. But I don't think this is the case. At least not for vn_protocol_renderer_info.h.

Automatically generated files come from vkr_device_object.json, right?

Anything under the src/venus/venus-protocol directory with the vn_protocol_renderer_ prefix is output generated from the vn_protocol.py script in venus-protocol.

Since this file is generated, the indices will get updated when regenerating the protocol to add new extensions meaning both the vkr_extension_table and vk_info_extension list are kept in sync (otherwise thats a bug ;)). vkr just decides which extensions it wants enabled.

In general, when adding a new extension you should update the scripts and have the newly generated files replace the ones in both the driver (mesa) and the renderer (virglrenderer) instead of modifying them.

Got it. I was editing the files by hand all along
Thanks!

Yeah, that's the expectation.

Because venus-protocol is shared by both virglrenderer and Mesa, and is referenced by virtio-gpu spec, it is not commited to either of the projects. It is a bit annoying that we end up committing generated files to both projects.

changed the description

changed the description

changed the description

added 2 commits

• 3640597b - venus: minor vkr_context_create refactor
• 0a0aa75e - venus: refactor extension spect list

Compare with previous version

changed title from venus: minor refactors to venus: minor refactor

changed the description

Reviewed-by: Chia-I Wu <olvaffe@gmail.com> with or without labels renamed

added 2 commits

• ddf7da25 - 1 commit from branch virgl:master
• 175931d1 - venus: minor vkr_context_create refactor

Compare with previous version

added 1 commit

• 482af27c - venus: minor vkr_context_create refactor

Compare with previous version

enabled an automatic merge when the pipeline for 482af27c succeeds

merged