Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 85
    • Issues 85
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • virgl
  • virglrenderer
  • Merge requests
  • !675

vkr: Use vkGetDeviceQueue with queues that created with flags zero

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrii Pauk requested to merge apauk/virglrenderer:vkr-fix-get-queue into master Jan 13, 2022
  • Overview 5
  • Commits 1
  • Pipelines 4
  • Changes 1

This is a fix for segfault issue, because of usage of uninitialized vkQueue handle.

Spec 1 states that vkGetDeviceQueue must only be used to get queues that were created with the flags parameter of VkDeviceQueueCreateInfo set to zero. To get queues that were created with a non-zero flags parameter use vkGetDeviceQueue2.

The problem that in case queue was created with flags set to zero following vkGetDeviceQueue2 call will fail. By failing I mean that pQueue set to NULL, which later leads to segfault.

This problem was also reported by vulkan validation layer:

vkr: vkGetDeviceQueue2: value of pQueueInfo->flags must not be 0. The Vulkan spec states: flags must not be 0 (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkDeviceQueueInfo2-flags-requiredbitmask)

Signed-off-by: Andrii Pauk Andrii.Pauk@opensynergy.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: vkr-fix-get-queue