Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !657

formats: Fix readback condition for depth buffers

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged 小田喜陽彦 requested to merge akihiko.odaki/virglrenderer:formats into master Dec 07, 2021
  • Overview 3
  • Commits 1
  • Pipelines 6
  • Changes 1

The old implementation of vrend_add_formats used to check color readback format even if a depth buffer is bound. As no texture is attached to the color buffer for such a FBO, it makes glGetIntegerv with GL_IMPLEMENTATION_COLOR_READ_TYPE fail, and the error can trigger the GL_NO_ERROR assertion in the function.

Check only if the depth buffer can be read in such a case.

Signed-off-by: Akihiko Odaki akihiko.odaki@gmail.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: formats