Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 87
    • Issues 87
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !638

formats: Enable more formats for readback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gert Wollny requested to merge gerddie/virglrenderer:enable-more-readback into master Oct 26, 2021
  • Overview 7
  • Commits 1
  • Pipelines 8
  • Changes 1

On OpenGL all textures can be read back using glGetTexture but for GLES we have to be able to bind the texture as render target, and glReadPixels must support the format, so the logic for GLES stays the same.

It may be possible to rely on the data that is stored in the IOV (the tweak proposed in mesa/mesa!13572 (merged) proves this for CS:GO), but there is a number of reasons why we can't rely on this data always being valid, that's why I didn't touch the GLES logic with this version patch.

Edited Oct 28, 2021 by Gert Wollny
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: enable-more-readback