Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 33
    • Merge requests 33
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !634

vrend/shader: Set all FS output locations if possible

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Gert Wollny requested to merge gerddie/virglrenderer:fix-fs-output-layout into master Oct 19, 2021
  • Overview 5
  • Commits 1
  • Pipelines 6
  • Changes 4

Sometimes we receive FS shaders where some output was optimized away. In this case we have to set the output locations explicitly, but it is no problem if we always do this. On GL this can always be done by using glBindFragDataLocationIndexed, it is supported since at least GL 3.3, and the alternative, setting the layouts in the shader, requires the same OpenGL. On GLES we have to emit explict locations if EXT_blend_func_extended is not supported. This fixes rendering of "The Long Dark".

Related: #223 (closed)

@jbates

Edited Oct 19, 2021 by Gert Wollny
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-fs-output-layout